cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Remove dials dependency from FormatSMVTimePix #724

Closed ndevenish closed 2 months ago

ndevenish commented 2 months ago

This made constructing the dxtbx format registry contingent on dials being present; a circular dependency. Switch to scitbx.array_family.flex instead.

This only occured when running full regression tests with dxtbx and dials_regression, which is probably why it wasn't noticed before.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.22%. Comparing base (61b5a40) to head (8c00e9f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #724 +/- ## ======================================= Coverage 42.22% 42.22% ======================================= Files 187 187 Lines 16802 16802 Branches 3207 3207 ======================================= Hits 7095 7095 Misses 9061 9061 Partials 646 646 ```