search

cctbx / dxtbx

Diffraction Experiment Toolbox
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Tweak gain for ELDICO ED-1 #732

Closed dagewa closed 2 months ago

dagewa commented 2 months ago

Following discussion with ELDICO it seems the previously assumed gain of 3.0 is not really verified. The gain appears closer to 1.7-1.8, but this is not precisely known either. Rather than making bad assumptions, just reset to 1.0 and allow the user to override at import.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.75%. Comparing base (5289332) to head (49e9cd1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #732 +/- ## ======================================= Coverage 41.75% 41.75% ======================================= Files 187 187 Lines 16853 16852 -1 Branches 3224 3224 ======================================= Hits 7037 7037 - Misses 9165 9169 +4 + Partials 651 646 -5 ```