Font issue with the plus and minus button

cculianu / DonateSpareChange

A plugin for Electron Cash to automatically donate "change" outputs below a certain amount to charity.

3 stars 1 forks source link

Font issue with the plus and minus button #4

Closed EchterAgo closed 5 years ago

EchterAgo commented 5 years ago

The plus and minus buttons use unicode symbols (Heavy plus / minus sign) that seem to not be available in every font. Sploit reported this in Telegram and I saw the same issue in the Qt Designer. This should either be switched to normal plus and minus symbols or replaced with a Vector graphic.

cculianu commented 5 years ago

Yikes! Yeah I'll fix it soon! Thanks for the issue! ! :)

EchterAgo commented 5 years ago

This seems to actually be caused by missing fonts. The box / box with number indicates it could not resolve a glyph for the character. For me it was solved by installing noto-fonts-emoji on Arch.

cculianu commented 5 years ago

Is it just me or is designer notoriously careless about embedding reasonably cross platform font descriptions on the .ui file?

I’m always super scared to touch the font setting for a widget because it seems to go out of its way to break every damn time I do.

Ha ha

EchterAgo commented 5 years ago

Hmm, it seems that as long as you don't touch the font family you should be fine cross platform wise. To do that you need to expand the font entry. If you accidentally touched the family, just reset it. For example if I set some font to size 50 it generates this code:

font = QtGui.QFont()
font.setPointSize(50)
self.tb_plus.setFont(font)

EchterAgo commented 5 years ago

Like this:

There should be no reset button next to the font family. If there is, click it and it will remove that property.

cculianu commented 5 years ago

Yeah you are right. I "knew" this but forgot it when developing the plugin. It's all coming back now. "Just don't touch the font family" is the dictum. I remember now. Will do.