Layout on iPhone X - The "notch" interferes with some layouts.

cculianu / Electron-Cash

Electron Cash; Bitcoin Cash thin client

http://www.electroncash.org

MIT License

6 stars 3 forks source link

Layout on iPhone X - The "notch" interferes with some layouts. #8

Closed cculianu closed 6 years ago

cculianu commented 6 years ago

Suggestion: padding that side with the notch. shakes fist at Apple

Provided by "Devar" from slack.

"I just realised the wallet supports orientation. Unfortunately this breaks a fair but of the UI as the infamous notch covers some of the display area. the right hand side in this case.. wait... and if i have the notch on the left hand side... interfers with the rendering. You'll have to introduce some padding the side depending on detected orientation so text/boxes are not rendered under the notch"

Devar commented 6 years ago

Particularly an issue on the following screens:

Wallets main screen
Transaction Details
Address Details
Coin Info
Address Converter
Network settings

cculianu commented 6 years ago

Ok, I think I fixed this. I'll push out a build soon and when I do I'll let you know and if it looks fine, we can close this issue. Thanks again for reporting this!

Devar commented 6 years ago

Tested all these screens in all orientations and overlap with notch is now fixed.

cculianu commented 6 years ago

Dude you're a rockstar. Thanks again for all the great insights thus far.

Ok, closing the issue.