search

cculianu / Fulcrum

A fast & nimble SPV Server for BCH, BTC, and LTC
Other
325 stars 73 forks source link

Support building with shared simdjson library. #152

Open jeandudey opened 1 year ago

jeandudey commented 1 year ago

On GNU Guix there's a strict policy of removing any bundled sources on projects and linking against libraries that are present in the distribution already. I've managed to compile Fulcrum without simdjson bundled by applying a few patches to the source code and it seems to work fine, however, I don't know if there are any patches applied other than the one for fixing a compiler warning.

It'd be great if there was an option to specify when calling qmake like using LIBS=-lsimdjson and to make it automatically only include the simdjson.h header.

cculianu commented 1 year ago

Ah, I am not familiar (yet) with GUIX but I do know Core uses it to build Bitcoin Core. Yes, the only patch I applied that differs from official is that one that keeps a compiler warning at bay.

It'd be great if there was an option to specify when calling qmake like using LIBS=-lsimdjson and to make it automatically only include the simdjson.h header.

I wasn't even aware that anybody on the planet would opt to compile and install the non-header-only simdjson. Given that you are telling me GUIX's own "distro" (build env?) does include it, I can add it to the options, for sure. Let me keep this issue open and hopefully get to do that soon.