cculianu / Fulcrum

A fast & nimble SPV Server for BCH, BTC, and LTC
Other
341 stars 77 forks source link

sendrawtransaction broken for non-zero burn transactions in core 25.0 #181

Closed BamaHodl closed 1 year ago

BamaHodl commented 1 year ago

Recently bitcoin core added an optional parameter to the sendrawtransaction call to limit intentional burns. It was implmented in this commit. This was released in Bitcoin Core 25.0.

Whereas there was no default limit prior to 25.0, the default is now set to 0, meaning sending non-zero values to OP_RETURN via sendrawtransaction will fail by default.

To keep pre-25.0 functionality intact, users of that RPC call (electrum servers, among others) will need to send the new maxburnamount parameter in the RPC call, which will also require sending the previously unset maxfeerate.

cculianu commented 1 year ago

This has been fixed by #182