search

cculianu / Fulcrum

A fast & nimble SPV Server for BCH, BTC, and LTC
Other
339 stars 76 forks source link

Correct typos in example configurations #247

Closed The00Dustin closed 5 months ago

The00Dustin commented 5 months ago

Correction of minor spelling and example errors. Servers.cpp uses %1 to pull server info, so I am assuming the banner typo only exists in the config description. Options.cpp uses QString("%1:%2") to parse the argument with the conflicting examples, so I assume the colon is required when providing server and port. If the intent of the example was to indicate that one can list only a server without a port (where the default is only a port already), then it was ambiguous and further editing may be desirable (perhaps to simply remove the port from the first example since it is shown as the default already).

cculianu commented 5 months ago

Servers.cpp uses %1 to pull server info

Servers.cpp isn't parsing the conf file. App.cpp is. I am not sure what you mean here.

Aside from the 'Fulcruim' typoes (lol!) -- I am also not sure why you want to change the other examples. I feel the colon is warranted.. care to explain?

The00Dustin commented 5 months ago

Servers.cpp isn't parsing the conf file. App.cpp is. I am not sure what you mean here.

static const QString bannerFallback = QString("Connected to a %1 server").arg(ServerMisc::AppSubVersion);

I am also not sure why you want to change the other examples. I feel the colon is warranted.. care to explain?

I added the colon because it looked to me like it was missing. It occurred to me afterwards that maybe that was intentional, like to imply that localhost was a valid value in addition to 9050 being a valid entry (if they are, in spite of QString("%1:%2")). If that isn't the case, then maybe the commented value needs fixed, too...

cculianu commented 5 months ago

Servers.cpp isn't parsing the conf file. App.cpp is. I am not sure what you mean here.

static const QString bannerFallback = QString("Connected to a %1 server").arg(ServerMisc::AppSubVersion);

This is completely unrelated to the conf file... how is that line of code relevant to what we are discussing here? That's just the server banner stuff.

I am also not sure why you want to change the other examples. I feel the colon is warranted.. care to explain?

I added the colon because it looked to me like it was missing. It occurred to me afterwards that maybe that was intentional, like to imply that localhost was a valid value in addition to 9050 being a valid entry (if they are, in spite of QString("%1:%2")). If that isn't the case, then maybe the commented value needs fixed, too...

Yeah I misread your diff. Yes, adding the colon is good.