search

ccutrer / openhab-jrubyscripting

JRuby Libraries for Openhab
Eclipse Public License 2.0
1 stars 1 forks source link

support timer.DateTimeTrigger #177

Closed ccutrer closed 1 year ago

ccutrer commented 1 year ago

I'm not 100% sold on the method name. And the simplicity of the method name is why I didn't create a terse form.

jimtng commented 1 year ago

Yeah, the name kinda makes you think you could say "at 5pm" instead of giving it a datetimeitem. datetime_trigger doesn't flow quite well either, but it's pretty clear

jimtng commented 1 year ago

Maybe we can support LocalTime | Time | Date | ZonedDateTime | MonthDay | try_parse_time_like(str)

at "7pm"
ccutrer commented 1 year ago

you can already do that with every :day, at: "7pm". the beauty of this trigger is the triggering time is dynamic, based on the state of some other item

jimtng commented 1 year ago

you can already do that with every :day, at: "7pm". the beauty of this trigger is the triggering time is dynamic, based on the state of some other item

Yes, I'm aware. Just thinking of making "at" more natural. When given a static time, we'd implement it with every/cron