install from git to fix timing issues on new tag

ccutrer / waterfurnace_aurora

Library for communication with WaterFurnace Aurora control systems

31 stars 7 forks source link

install from git to fix timing issues on new tag #8

Closed mdallaire closed 2 years ago

mdallaire commented 2 years ago

On the last tag I noticed that the first build failed, probably due to a small delay between your new tag and rubygems.org. I changed the docker build file to use the git repo as a source for waterfurnace_aurora to avoid that race condition.

mdallaire commented 2 years ago

I went through the aurora_mqtt_bridge and added state_class where it made sense. I have absolutely zero Ruby knowledge so just make sure you double check. I also removed the device_class: power from the current-mode device.

ccutrer commented 2 years ago

I've pulled in some, but not all, commits in this PR:

remove GitHub actor from image name brought directly in
use state_class: manually pulled in because you had syntax errors, and also applied it to a couple more

I did not pull in building the dockerfile from git instead of rubygems. I'm not sure how I feel about it. Can you instead just delay the build, or retry a few times over 5 minutes?

mdallaire commented 2 years ago

It looks like the last few docker images were built without problem. I will just close the PR and if it come up again I'll revisit this.