search

ccw-ide / ccw

Counterclockwise is an Eclipse plugin helping developers write Clojure code
https://github.com/laurentpetit/ccw/wiki/GoogleCodeHome
Eclipse Public License 1.0
218 stars 49 forks source link

False detection of a hyperlink in a String literal #847

Closed noncom closed 8 years ago

noncom commented 8 years ago

I just came across a case where a hyperlink is incorrectly detected in a String literal.

The literal:

(println "========================================================================== debug :")

Various stages of the issue:

laurentpetit commented 8 years ago

Which OS do you use? I cannot reproduce this issue on my OS X.

noncom commented 8 years ago

Probably a Windows-specific problem with paths. The java-resource-paths strategy was failing when appending the "path" taken from the string literal to the projects root-path where org.eclipse.core.runtime.Path was silently dropping the appendage off because it containted the illegal : character, and was effectively returning the root-path as the target for the incorrectly-assumed hyperlink in the String literal.

Per out talk, the PR applies a patch that prevents java-resource-paths strategy from considering folders as valid targets.