search

ccw-ide / ccw

Counterclockwise is an Eclipse plugin helping developers write Clojure code
https://github.com/laurentpetit/ccw/wiki/GoogleCodeHome
Eclipse Public License 1.0
218 stars 49 forks source link

make java-resource-paths file find strategy ignore folders #848

Closed noncom closed 8 years ago

noncom commented 8 years ago

Fix for https://github.com/laurentpetit/ccw/issues/847

laurentpetit commented 8 years ago

Thanks for the PR!

Can you please add a line to the ChangeLog file. You'll see lots of examples in there for referencing the github issue, etc.

laurentpetit commented 8 years ago

Also, for commit message, we stick to the anguar project convention. I've added a line on this in the CONTRIBUTING guide: https://github.com/laurentpetit/ccw/blob/master/CONTRIBUTING.adoc#issue-reporting

noncom commented 8 years ago

Ooops :) sorry! I did not think of all this :) Now I followed what you're saying and now it looks more suitable. Though I am not sure if the commit message and the ChangeLog entry are correct.. doing this for the first time and also never heard of the Angular JS commit formulation convention before, but I like it :) Could you please take a look?

A technical question: why do you tend to avoid the Eclipse internal package?

arichiardi commented 8 years ago

Usually the internal packages are implementazione details that one should avoid relying upon...they might change very frequenty..or at least this is what experience has taught me so far :smile:

laurentpetit commented 8 years ago

Can you please squash these 2 commits into a single one? Also, can you add (if missing) an import for the IResource class, and just use IResource in the code?

noncom commented 8 years ago

Seems done! Now I know a little more of Git :)

laurentpetit commented 8 years ago

Cool thanks !

laurentpetit commented 8 years ago

Done, your first PR is integrated ! Congrats and welcome on board !

noncom commented 8 years ago

Thank you! Glad we made it working! It is really cool to take part.

arichiardi commented 8 years ago

:balloon: :dancers: