search

ccwalletio / tracker

An issue tracker for ccwallet.io feature requests
25 stars 2 forks source link

Messages in Eternl are signed with wrong address #167

Open BartolomeoItaliano opened 1 month ago

BartolomeoItaliano commented 1 month ago

Hello recently my Dapps stopped working with your wallet only. I investigated the issue and it looks like there is a bug in signData method.

I sign the data like this:

const hexedAddress1 = "someHexedAddress";
const hexedData = "someHexedData";
const api = await window.cardano.eternl.enable();
const signedData =  api.signData(hexedAddress1, hexedData);

Then I review signature:

const builder = CoseSign1.fromCbor(signedData.signature);
const hexedAddress2 = Address.from_bytes(builder.getAddress()).to_hex();

And it ends up:

hexedAddress1 differs from hexedAddress2

I tried to change the wallet, restart my browser and it did not help. I believe it to be an important issue. Users cannot log in to my pages right now. Please help.

Scitz0 commented 1 month ago

This issue has been identified and a fix is already available to be included in the next release. Shouldn't take more than a few days. Beta extension should already have it I think.