ccwienk / temper

Simple python for accessing TEMPer USB thermometers
MIT License
35 stars 27 forks source link

Add docker support for temper.py #15

Closed neofob closed 1 year ago

neofob commented 1 year ago

The dockerization effort is sponsored by Greenfly SAU LLC.

cc: @greenmoss

eode commented 1 year ago

Looks good overall. Can you change the default port to 2610, which isn't in the default debian /etc/services? Realistically, all fairly low ports have been used at one point or another, but 2610 will be a bit less common.

Also, it could use a bit of reference in the README.md - perhaps just mention that it can be run as a docker service, with the relevant commands (like you have in the docker.md)?

neofob commented 1 year ago

Will do that! Thanks for the feedback!

neofob commented 1 year ago

@eode @ccwienk : The patch should be good to be merged after new changes.

eode commented 1 year ago

Excellent! Thanks for your contribution.