search

ccwienk / temper

Simple python for accessing TEMPer USB thermometers
MIT License
35 stars 27 forks source link

Add support for TEMPer1F_H1V1.5F #28

Closed urwen closed 3 weeks ago

urwen commented 10 months ago

Firmware TEMPer1F_H1V1.5F (id 0c45:7402) seems to be using a different temperature sensor (SHT20). This change adds support for this sensor/firmware combination.

urwen commented 10 months ago

BTW, I have rebased all of your changes onto urwen/temper. There is one PR over there you should look at, because I think it's a one-line change to support another version: https://github.com/urwen/temper/pull/29

I want to thank you for forking temper and maintaining it for these past several years. I really appreciate it!!! I've put a note in my README.md to point to this repository, and I'll submit changes here if I add support for more devices.

ccwienk commented 8 months ago

@urwen : npb. however, I think "maintaining" is giving me too much credit. basically, I forked it once to add a fix I needed, and then I actually almost forgot about the fork 🙈

I think I just caused a conflict by admitting another pullrequest that proposed the same change :(

ccwienk commented 3 months ago

@urwen : I made you collaborator

eode commented 3 weeks ago

@ccwienk @urwen I've just merged this branch -- I don't know if you two are active still, but just wanted to let you know.

Should we try to merge these two repos fully, and go with one over the other, going forward?