ccxt-net / ccxt.net

CCXT.NET – CryptoCurrency eXchange Trading Library for .NET
MIT License
195 stars 67 forks source link

the different between FetchMarkets method on public API and LoadMarkets #4

Closed lisa3907 closed 5 years ago

lisa3907 commented 5 years ago

MAIL-FROM: Andrew Tollervey andrew.tollervey@hotmail.co.uk

Hi there,

Firstly, good work on your ccxt.net. It must have taken you a good while.

Quick question regarding - https://github.com/lisa3907/ccxt.net

Can you explain the different between FetchMarkets method on public API and LoadMarkets in your base library, and why I would use one over the other in various scenarios…

Many thanks,

Andrew
p.s. I added a possible fix to a bug - kraten publicApi.cs file:

added following within FetchMarkets method:

if ((_market.baseId.Substring(0, 1) == "X" || _market.baseId.Substring(0, 1) == "Z") && _market.baseId.Length > 3)
lisa3907 commented 5 years ago
if ((_market.baseId.Substring(0, 1) == "X" || _market.baseId.Substring(0, 1) == "Z") &&  arket.baseId.Length > 3)

Bug FIX: reason Tezos (XTZ) coin

lisa3907 commented 5 years ago
Can you explain the different between FetchMarkets method on public API and LoadMarkets in your base library, and why I would use one over the other in various scenarios…

The difference between FetchMarkets and LoadMarkets is the difference between caching and downloading information directly. When LoadMarkets is called for the first time after execution, it calls FetchMarkets and stores it in the cache.

lisa3907 commented 5 years ago

MAIL-FROM: Andrew Tollervey andrew.tollervey@hotmail.co.uk

Good idea for doing caching. 

I think I may have found another bug.

file: privateApi.cs
Namespace: CCXT.NET.Bithumb.Private

If you look at various methods with the following "IF" statement:
if (!nameResult1.success)

looking at it, I think the ! should be removed from the above line of code, otherwise whenever success == true, "Not supported yet" will always be returned.
lisa3907 commented 5 years ago

I don’t understand your found bug. My coding style do not write like “if (!result)”. What is line number in privateApi.cs.

Tollervey commented 5 years ago

You can close this as it appears my local code doesn't match your latest version so will update myside based upon latest code. Regards...