cda-group / arc

Programming Language for Continuous Deep Analytics
https://cda-group.github.io/arc/
44 stars 6 forks source link

LLVM submodule update #323

Closed frej closed 3 years ago

frej commented 3 years ago

Many arithmetic operations have moved from the std dialect to the arith dialect:

std.addf -> arith.addf std.and -> arith.andi std.cmpf -> arith.cmpf std.cmpi -> arith.cmpi std.constant -> arith.constant std.divf -> arith.divf std.mulf -> arith.mulf std.or -> arith.ori std.ord -> arith.ori std.remf -> arith.remf std.subf -> arith.subf std.xor -> arith.xori

Apart from the changes in operation names, the move also complicates materialization of constants as the arith::ConstantOp instances are no longer an instance of mlir::ConstantOp. This requires changes to the canonicalizers, constant folders, and arc-to-rust lowering. The arith-dialect also has to be added to the dialects known by the arc-mlir tool.