search

cda-group / arc

Programming Language for Continuous Deep Analytics
https://cda-group.github.io/arc/
44 stars 6 forks source link

Rewrite compiler for Arc-Lang (previously Arc-Script) into OCaml #347

Closed segeljakt closed 2 years ago

segeljakt commented 2 years ago

This PR adds a compiler for Arc-Lang, written in OCaml. It also updates the README and documentation.

frej commented 2 years ago

How much work would it be to break up this into logical chunks that would still allow us to bisect it? Is it possible at all? If not, the right thing is to just squash all of them, as we're not going to be helped (during future debugging) by an incremental change that only says "Update Foo".

segeljakt commented 2 years ago

How much work would it be to break up this into logical chunks that would still allow us to bisect it? Is it possible at all? If not, the right thing is to just squash all of them, as we're not going to be helped (during future debugging) by an incremental change that only says "Update Foo".

Each commit touches a specific part of the repo. In my opinion, maybe it is best to squash because the changes either introduce something completely new or overhaul old functionality. I think the 5 last commits could be squashed and moved up so they are before the compiler / runtime switch.

segeljakt commented 2 years ago

I can show what I mean 👀

frej commented 2 years ago

In my opinion, maybe it is best to squash because the changes either introduce something completely new or overhaul old functionality.

That's what I suspected, go for the squash.