search

cda-group / arcon

State-first Streaming Applications in Rust
https://cda-group.github.io/arcon/
Apache License 2.0
175 stars 17 forks source link

removed redundant gauge call from node manager #245

Closed Sanskar95 closed 3 years ago

Sanskar95 commented 3 years ago

Fixes #244

Max-Meldrum commented 3 years ago

Great! There is a warning for unused import use std::time::Insant line 27 in src/manager/node.rs when running with default features. The import should be under #[cfg(feature = "metrics")]

And while you are at it, could you add in run_checks.sh another line that runs clippy without all-features.

cargo clippy --workspace --all-targets  -- -D warnings

We probably need this check at the CI level as well, but useful for catching potential warnings locally.