cda-group / arcon

State-first Streaming Applications in Rust
https://cda-group.github.io/arcon/
Apache License 2.0
175 stars 17 forks source link

chore: bump prost to 0.9 #310

Closed skyzh closed 2 years ago

skyzh commented 2 years ago

Signed-off-by: Alex Chi iskyzh@gmail.com

close https://github.com/cda-group/arcon/issues/208

I've met with some compile error on my computer... Not sure if this would pass CI.

warning: unknown lint: `clippy::uninit_vec`
   --> arcon/src/buffer/event/mod.rs:217:13
    |
217 |     #[allow(clippy::uninit_vec)]
    |             ^^^^^^^^^^^^^^^^^^ help: did you mean: `clippy::unit_arg`
    |
    = note: `#[warn(unknown_lints)]` on by default

error: non-item macro in item position: panic
  --> arcon/src/index/hash_table/mod.rs:36:9
   |
36 |         panic!("sse2 needed for now");
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0432]: unresolved import `super::EMPTY`
 --> arcon/src/index/hash_table/generic.rs:4:31
  |
4 | use super::{bitmask::BitMask, EMPTY};
  |                               ^^^^^ no `EMPTY` in `index::hash_table`

warning: unnecessary trailing semicolon
  --> arcon/src/index/hash_table/generic.rs:61:10
   |
61 |         };
   |          ^ help: remove this semicolon
   |
   = note: `#[warn(redundant_semicolons)]` on by default

error[E0599]: no method named `convert_mod_to_safe` found for struct `index::hash_table::generic::Group` in the current scope
   --> arcon/src/index/hash_table/table.rs:937:41
    |
937 |                 self.group = self.group.convert_mod_to_safe(self.table.meta(self.pos));
    |                                         ^^^^^^^^^^^^^^^^^^^ method not found in `index::hash_table::generic::Group`
    |
   ::: arcon/src/index/hash_table/generic.rs:40:1
    |
40  | pub struct Group(GroupWord);
    | ---------------------------- method `convert_mod_to_safe` not found for this

error[E0599]: no method named `convert_mod_to_safe` found for struct `index::hash_table::generic::Group` in the current scope
    --> arcon/src/index/hash_table/table.rs:1025:41
     |
1025 |                 self.group = self.group.convert_mod_to_safe(self.table.meta(self.pos));
     |                                         ^^^^^^^^^^^^^^^^^^^ method not found in `index::hash_table::generic::Group`
     |
    ::: arcon/src/index/hash_table/generic.rs:40:1
     |
40   | pub struct Group(GroupWord);
     | ---------------------------- method `convert_mod_to_safe` not found for this

Some errors have detailed explanations: E0432, E0599.
For more information about an error, try `rustc --explain E0432`.
warning: `arcon` (lib) generated 2 warnings
error: could not compile `arcon` due to 4 previous errors; 2 warnings emitted
warning: build failed, waiting for other jobs to finish...
warning: `arcon` (lib test) generated 2 warnings (2 duplicates)
error: build failed
skyzh commented 2 years ago

Well, it is because that I'm using M1 Mac. I'll switch to another machine to see if this compiles...

skyzh commented 2 years ago

It compiles my my PC, and all tests pass, so the CI should pass. (An approval for CI workflow is required)

... by the way, it seems that the Zulip invitation doesn't work. There a message on the web page:

You need an invitation to join this organization.

Is there any way to join the community chat? Thanks!

Max-Meldrum commented 2 years ago

It compiles my my PC, and all tests pass, so the CI should pass. (An approval for CI workflow is required)

... by the way, it seems that the Zulip invitation doesn't work. There a message on the web page:

You need an invitation to join this organization.

Is there any way to join the community chat? Thanks!

Hey! Thanks for telling me about the community chat issues. I have enabled it now so anyone can join.

Yeah, currently some issues regarding compilation with ARM (#161)

Max-Meldrum commented 2 years ago

Merging, nice work!