cda-tum / mqt-core

MQT Core - The Backbone of the Munich Quantum Toolkit
http://mqt.readthedocs.io/projects/core
MIT License
52 stars 28 forks source link

🩹 disentangle `mqt-core-dd` and `mqt-core-algo` #670

Closed burgholzer closed 4 weeks ago

burgholzer commented 4 weeks ago

Description

This PR is a follow-up to #668 and fixes an overlooked dependency of the mqt-core-dd library on the mqt-core-algo library that somehow went unnoticed in the original PR. To this end, this PR reverts parts of #452 and moves the respective benchmarking code to the evaluation target.

Checklist:

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.0%. Comparing base (2662795) to head (e2a9287).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-core/pull/670/graphs/tree.svg?width=650&height=150&src=pr&token=MqstsRKdqp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-core/pull/670?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #670 +/- ## ======================================= - Coverage 92.0% 92.0% -0.1% ======================================= Files 127 125 -2 Lines 13911 13809 -102 Branches 2177 2171 -6 ======================================= - Hits 12810 12707 -103 - Misses 1101 1102 +1 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-core/pull/670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-core/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `91.7% <ø> (-0.1%)` | :arrow_down: | | | [python](https://app.codecov.io/gh/cda-tum/mqt-core/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `99.7% <ø> (ø)` | | Carriedforward from [298debf](https://app.codecov.io/gh/cda-tum/mqt-core/commit/298debfb7f87823eca5386847863f8b6ad586a4e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/cda-tum/mqt-core/pull/670/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)