search

cda-tum / mqt-ddsim

MQT DDSIM - A quantum circuit simulator based on decision diagrams written in C++
https://mqt.readthedocs.io/projects/ddsim
MIT License
141 stars 30 forks source link

🩹 make sure to define `Py_GIL_DISABLED` on Windows for Python 3.13t #425

Closed burgholzer closed 2 months ago

burgholzer commented 2 months ago

Description

As pointed out in https://github.com/pypa/cibuildwheel/issues/1975#issuecomment-2296995654 free-threading (Python 3.13t) builds on Windows need to have Py_GIL_DISABLED set in order to properly work. This PR ensures that the corresponding setting is always set.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.3%. Comparing base (15a0c7c) to head (c6c97fd). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-ddsim/pull/425/graphs/tree.svg?width=650&height=150&src=pr&token=OxwtOXYQeG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-ddsim/pull/425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #425 +/- ## ===================================== Coverage 92.3% 92.3% ===================================== Files 37 37 Lines 2721 2721 Branches 305 304 -1 ===================================== Hits 2513 2513 Misses 208 208 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-ddsim/pull/425/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-ddsim/pull/425/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `94.1% <ø> (ø)` | | | [python](https://app.codecov.io/gh/cda-tum/mqt-ddsim/pull/425/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `87.4% <ø> (ø)` | | [see 2 files with indirect coverage changes](https://app.codecov.io/gh/cda-tum/mqt-ddsim/pull/425/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)