search

cda-tum / mqt-qao

MQT Quantum Auto Optimizer - A MQT Tool for Solving Optimization Problems with Quantum Computers
MIT License
13 stars 0 forks source link

Framework update #26

Closed DeborahVolpe closed 1 month ago

DeborahVolpe commented 1 month ago

Framework update for the quantum week presentation

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 57.66423% with 116 lines in your changes missing coverage. Please review.

Project coverage is 54.2%. Comparing base (9b45b8d) to head (c37e3e2). Report is 1 commits behind head on main.

Files Patch % Lines
src/mqt/qao/solvers.py 57.6% 116 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ======================================= + Coverage 53.1% 54.2% +1.0% ======================================= Files 6 6 Lines 2815 3033 +218 ======================================= + Hits 1496 1644 +148 - Misses 1319 1389 +70 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-qao/pull/26/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/cda-tum/mqt-qao/pull/26/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `54.2% <57.6%> (+1.0%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DeborahVolpe commented 1 month ago

Just did a quick round of fixes and updated some things. See the individual commits for details. Overall, this should be good to go. You might want to also add your new QCE publication to the docs/refs.bib and cite it in the documentation. Thank you so much. I have also added the reference here. I have forgotten this point

One thing i noticed is that the solvers.py file contains huge amounts of code duplication and is probably 5x longer than it needs to be. However, this is nothing to be changed in this PR, but maybe something to keep in mind for a potential future refactor.

Yes, thank you.