cda-tum / mqt-qcec

MQT QCEC - A tool for Quantum Circuit Equivalence Checking
https://mqt.readthedocs.io/projects/qcec
MIT License
90 stars 21 forks source link

♻️ Simplify Timeout Handling #232

Closed burgholzer closed 1 year ago

burgholzer commented 1 year ago

Description

In the past, the way timeouts could be set was handled quite awkwardly by relying on pybind's automatic conversion from std::chrono::seconds to some Python datetime object. This PR simplifies the overall handling by changing the type of the timeout configuration parameter to a double.

Fixes #176

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #232 (6117383) into main (bab3977) will increase coverage by 0.1%. The diff coverage is 94.4%.

@@           Coverage Diff           @@
##            main    #232     +/-   ##
=======================================
+ Coverage   96.8%   97.0%   +0.1%     
=======================================
  Files         33      33             
  Lines       1707    1710      +3     
  Branches     210     210             
=======================================
+ Hits        1654    1659      +5     
+ Misses        53      51      -2     
Flag Coverage Δ
cpp 97.0% <94.1%> (+0.1%) :arrow_up:
python 96.9% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/EquivalenceCheckingManager.hpp 100.0% <ø> (ø)
src/EquivalenceCheckingManager.cpp 98.0% <93.3%> (+<0.1%) :arrow_up:
include/Configuration.hpp 96.2% <100.0%> (ø)
mqt/qcec/parameterized.py 95.5% <100.0%> (ø)
src/checker/dd/DDEquivalenceChecker.cpp 92.6% <0.0%> (+1.8%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.