cda-tum / mqt-qcec

MQT QCEC - A tool for Quantum Circuit Equivalence Checking
https://mqt.readthedocs.io/projects/qcec
MIT License
90 stars 21 forks source link

⬆️ update `mqt-core` #350

Closed burgholzer closed 9 months ago

burgholzer commented 9 months ago

Description

This PR was triggered by the failures in #349 and its purpose is to better isolate the changes into separate PRs.

has dropped the submodules in mqt-core and replaced them with FetchContent. As such, the googletest test dependency is no longer available at its typical location. Consequently, this PR now also uses FetchContent to get googletest. In a future PR, this will most likely be extended to the mqt-core submodule as well.

This should unblock #349.

Checklist:

github-actions[bot] commented 9 months ago

Cpp-Linter Report :warning:

Some files did not pass the configured checks!

clang-tidy reports: 1 concern(s) - include/checker/dd/TaskManager.hpp include/checker/dd/TaskManager.hpp:129:33: warning: [cppcoreguidelines-avoid-const-or-ref-data-members] > member 'package' of type 'std::unique_ptr &' (aka 'unique_ptr> &') is a reference ```hpp std::unique_ptr& package; ^ ```

Have any feedback or feature suggestions? Share it here.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (63e1b9e) 96.1% compared to head (1d8ff26) 96.3%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350/graphs/tree.svg?width=650&height=150&src=pr&token=eKL7Ya7iep&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #350 +/- ## ======================================= + Coverage 96.1% 96.3% +0.1% ======================================= Files 34 34 Lines 1750 1749 -1 Branches 214 214 ======================================= + Hits 1683 1685 +2 + Misses 67 64 -3 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `96.0% <100.0%> (+0.2%)` | :arrow_up: | | [python](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `97.2% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [include/checker/dd/TaskManager.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL1Rhc2tNYW5hZ2VyLmhwcA==) | `98.3% <100.0%> (ø)` | | | [include/checker/dd/simulation/StateGenerator.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL3NpbXVsYXRpb24vU3RhdGVHZW5lcmF0b3IuaHBw) | `97.2% <100.0%> (ø)` | | | [src/checker/dd/DDSimulationChecker.cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL2NoZWNrZXIvZGQvRERTaW11bGF0aW9uQ2hlY2tlci5jcHA=) | `100.0% <100.0%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)
burgholzer commented 9 months ago

Ignoring the linter failure here as it is fixed in #349