cda-tum / mqt-qcec

MQT QCEC - A tool for Quantum Circuit Equivalence Checking
https://mqt.readthedocs.io/projects/qcec
MIT License
87 stars 20 forks source link

:bug: Fix strip idle qubits #394

Closed TeWas closed 2 months ago

TeWas commented 2 months ago

Description

This PR fixes the issue of incorrectly removing idle qubits that are not idle in both circuits. The following changes have been made:

Fixes #372

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.08738% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 96.4%. Comparing base (cc1d2c3) to head (cd0898e). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394/graphs/tree.svg?width=650&height=150&src=pr&token=eKL7Ya7iep&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #394 +/- ## ======================================= - Coverage 96.5% 96.4% -0.2% ======================================= Files 35 35 Lines 1761 1818 +57 Branches 219 224 +5 ======================================= + Hits 1701 1754 +53 - Misses 60 64 +4 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `96.2% <97.0%> (-0.2%)` | :arrow_down: | | [python](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `97.2% <100.0%> (+<0.1%)` | :arrow_up: | | [Files](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [include/Configuration.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=include%2FConfiguration.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9Db25maWd1cmF0aW9uLmhwcA==) | `0.0% <ø> (ø)` | | | [include/EquivalenceCheckingManager.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=include%2FEquivalenceCheckingManager.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9FcXVpdmFsZW5jZUNoZWNraW5nTWFuYWdlci5ocHA=) | `100.0% <100.0%> (ø)` | | | [src/Configuration.cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=src%2FConfiguration.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL0NvbmZpZ3VyYXRpb24uY3Bw) | `100.0% <ø> (ø)` | | | [src/checker/zx/ZXChecker.cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=src%2Fchecker%2Fzx%2FZXChecker.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL2NoZWNrZXIvengvWlhDaGVja2VyLmNwcA==) | `100.0% <100.0%> (ø)` | | | [src/mqt/qcec/compilation\_flow\_profiles.py](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=src%2Fmqt%2Fqcec%2Fcompilation_flow_profiles.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL21xdC9xY2VjL2NvbXBpbGF0aW9uX2Zsb3dfcHJvZmlsZXMucHk=) | `97.5% <100.0%> (+<0.1%)` | :arrow_up: | | [src/mqt/qcec/configuration.py](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=src%2Fmqt%2Fqcec%2Fconfiguration.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL21xdC9xY2VjL2NvbmZpZ3VyYXRpb24ucHk=) | `100.0% <ø> (ø)` | | | [src/EquivalenceCheckingManager.cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=src%2FEquivalenceCheckingManager.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL0VxdWl2YWxlbmNlQ2hlY2tpbmdNYW5hZ2VyLmNwcA==) | `93.8% <98.7%> (+0.2%)` | :arrow_up: | | [...dd/applicationscheme/GateCostApplicationScheme.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2Fapplicationscheme%2FGateCostApplicationScheme.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL2FwcGxpY2F0aW9uc2NoZW1lL0dhdGVDb3N0QXBwbGljYXRpb25TY2hlbWUuaHBw) | `91.8% <71.4%> (-3.7%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/394/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)