search

cda-tum / mqt-qcec

MQT QCEC - A tool for Quantum Circuit Equivalence Checking
https://mqt.readthedocs.io/projects/qcec
MIT License
87 stars 20 forks source link

🚨 Fix new warnings revealed by clang-tidy 18 #401

Closed burgholzer closed 1 month ago

burgholzer commented 2 months ago

Description

This PR aims to fix all the new warnings that were introduced in clang-tidy versions 18, which have been enabled with the switch to the mqt-workflows@v1.0.0.

The first commit, which will later be reverted, just triggers a full clang-tidy run on the whole codebase.

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.6%. Comparing base (015d0e6) to head (9d0da4e).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401/graphs/tree.svg?width=650&height=150&src=pr&token=eKL7Ya7iep&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #401 +/- ## ======================================= + Coverage 96.3% 96.6% +0.3% ======================================= Files 35 35 Lines 1818 1817 -1 Branches 224 224 ======================================= + Hits 1751 1757 +6 + Misses 67 60 -7 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `96.5% <100.0%> (+0.4%)` | :arrow_up: | | | [python](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `97.2% <ø> (ø)` | | Carriedforward from [015d0e6](https://app.codecov.io/gh/cda-tum/mqt-qcec/commit/015d0e6008c52dbb63556367010d1b27250f3cec?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) to find out more. | [Files](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [include/Configuration.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2FConfiguration.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9Db25maWd1cmF0aW9uLmhwcA==) | `0.0% <ø> (ø)` | | | [include/EquivalenceCheckingManager.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2FEquivalenceCheckingManager.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9FcXVpdmFsZW5jZUNoZWNraW5nTWFuYWdlci5ocHA=) | `100.0% <100.0%> (ø)` | | | [include/EquivalenceCriterion.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2FEquivalenceCriterion.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9FcXVpdmFsZW5jZUNyaXRlcmlvbi5ocHA=) | `88.8% <ø> (ø)` | | | [include/ThreadSafeQueue.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2FThreadSafeQueue.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9UaHJlYWRTYWZlUXVldWUuaHBw) | `95.0% <100.0%> (ø)` | | | [include/checker/EquivalenceChecker.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2Fchecker%2FEquivalenceChecker.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL0VxdWl2YWxlbmNlQ2hlY2tlci5ocHA=) | `100.0% <ø> (ø)` | | | [include/checker/dd/DDAlternatingChecker.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2FDDAlternatingChecker.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL0REQWx0ZXJuYXRpbmdDaGVja2VyLmhwcA==) | `100.0% <ø> (ø)` | | | [include/checker/dd/DDConstructionChecker.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2FDDConstructionChecker.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL0REQ29uc3RydWN0aW9uQ2hlY2tlci5ocHA=) | `83.3% <ø> (ø)` | | | [include/checker/dd/DDEquivalenceChecker.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2FDDEquivalenceChecker.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL0RERXF1aXZhbGVuY2VDaGVja2VyLmhwcA==) | `100.0% <ø> (ø)` | | | [include/checker/dd/DDSimulationChecker.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2FDDSimulationChecker.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL0REU2ltdWxhdGlvbkNoZWNrZXIuaHBw) | `100.0% <ø> (ø)` | | | [include/checker/dd/TaskManager.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2FTaskManager.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL1Rhc2tNYW5hZ2VyLmhwcA==) | `98.5% <100.0%> (ø)` | | | ... and [18 more](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/401?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | |