search

cda-tum / mqt-qcec

MQT QCEC - A tool for Quantum Circuit Equivalence Checking
https://mqt.readthedocs.io/projects/qcec
MIT License
90 stars 21 forks source link

♻️🩹 fix and improve MQT Core linking #446

Closed burgholzer closed 1 month ago

burgholzer commented 1 month ago

Description

A follow-up to #444 that fixes a particular linking issue and furthermore improves the overall library link time dependencies by removing the template code from the StateGenerator and moving the code to the .cpp file.

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.11765% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.3%. Comparing base (c634603) to head (dc4841b). Report is 1 commits behind head on main.

Files Patch % Lines
src/checker/dd/simulation/StateGenerator.cpp 94.1% 4 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446/graphs/tree.svg?width=650&height=150&src=pr&token=eKL7Ya7iep&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #446 +/- ## ======================================= - Coverage 95.4% 95.3% -0.2% ======================================= Files 40 40 Lines 1839 1838 -1 Branches 224 224 ======================================= - Hits 1755 1752 -3 - Misses 84 86 +2 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `95.6% <94.1%> (-0.2%)` | :arrow_down: | | [python](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `94.0% <ø> (ø)` | | | [Files](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [include/checker/dd/simulation/StateGenerator.hpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446?src=pr&el=tree&filepath=include%2Fchecker%2Fdd%2Fsimulation%2FStateGenerator.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-aW5jbHVkZS9jaGVja2VyL2RkL3NpbXVsYXRpb24vU3RhdGVHZW5lcmF0b3IuaHBw) | `100.0% <ø> (+4.1%)` | :arrow_up: | | [src/checker/dd/simulation/StateGenerator.cpp](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446?src=pr&el=tree&filepath=src%2Fchecker%2Fdd%2Fsimulation%2FStateGenerator.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL2NoZWNrZXIvZGQvc2ltdWxhdGlvbi9TdGF0ZUdlbmVyYXRvci5jcHA=) | `94.8% <94.1%> (-5.2%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/cda-tum/mqt-qcec/pull/446/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)