search

cda-tum / mqt-qudits

A Framework For Mixed-Dimensional Qudit Quantum Computing
https://mqt.readthedocs.io/projects/qudits
MIT License
17 stars 4 forks source link

Changed plot y-axis labels to more accurately express the values. #34

Closed gkpotter closed 3 months ago

gkpotter commented 4 months ago

I think it would be a good idea to update the y-axis labels from "Pr" to something like "Sqrt(Pr)" to reflect the actual values.

As of now, it is confusing to see "Pr" for a set of values which do not add up to 1.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.7%. Comparing base (bea16b8) to head (9418566). Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/mqt/qudits/visualisation/plot_information.py 0.0% 20 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34/graphs/tree.svg?width=650&height=150&src=pr&token=qDDZkemicI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) ```diff @@ Coverage Diff @@ ## main #34 +/- ## ======================================= - Coverage 72.8% 72.7% -0.2% ======================================= Files 108 108 Lines 5375 5370 -5 Branches 263 263 ======================================= - Hits 3917 3907 -10 - Misses 1458 1463 +5 ``` | [Flag](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [cpp](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `73.7% <ø> (ø)` | | Carriedforward from [a77366a](https://app.codecov.io/gh/cda-tum/mqt-qudits/commit/a77366a0d96d40d0e676d556283cb8d5e2de5a3f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | | [python](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | `72.3% <0.0%> (-0.2%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) to find out more. | [Files with missing lines](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum) | Coverage Δ | | |---|---|---| | [src/mqt/qudits/visualisation/plot\_information.py](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34?src=pr&el=tree&filepath=src%2Fmqt%2Fqudits%2Fvisualisation%2Fplot_information.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum#diff-c3JjL21xdC9xdWRpdHMvdmlzdWFsaXNhdGlvbi9wbG90X2luZm9ybWF0aW9uLnB5) | `0.0% <0.0%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/cda-tum/mqt-qudits/pull/34/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cda-tum)
gkpotter commented 3 months ago

Added configurable labels and made both plotting functions use HistogramWithErrors!

I did remove the default title because it does not seem to fit with the name of the class, but this is minor and could be changed back.