search

cdalvaro / github-vscode-theme-iterm

:octocat: GitHub VS Code Theme for iTerm
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
315 stars 22 forks source link

[BUG]: Cursor text is not visible #15

Closed wxh06 closed 5 months ago

wxh06 commented 6 months ago

Description of the bug

Cursor and Cursor text have the same color.

截屏2024-05-22 23.25.09.png

Steps To Reproduce

  1. Set theme to GitHub Dark Default, GitHub Dark Dimmed or GitHub Dark High Contrast.
  2. Enter any character in the shell.
  3. Press ← (left arrow).
  4. The character is no longer visible.

Additional Information

The cursor text can be clearly seen in VS Code.

截屏2024-05-22 23.43.13.png

cdalvaro commented 6 months ago

Hi @wxh06, thank you for opening this issue! I'll fix it asap!

cdalvaro commented 5 months ago

Hi, @wxh06 I'm really sorry for the delay. I hope to fix this soon 😥

In the meantime, you can check the Smart box cursor color in Settings > Profiles > Colors bellow the Cursors Colors section:

Screenshot 2024-06-05 at 10 23 36

cdalvaro commented 5 months ago

Fixed in:

Please @wxh06, close the issue if you consider the issue is solved. Thank you!

wxh06 commented 5 months ago

Do you plan to update the legacy themes? I love the legacy GitHub Dark

cdalvaro commented 5 months ago

Legacy color themes updated too!

I also have updated the Terminal.app themes.

wxh06 commented 5 months ago

LGTM! Thanks!

cdalvaro commented 5 months ago

LGTM! Thanks!

Great! Thank you for reporting this issue!