search

cdalvaro / github-vscode-theme-iterm

:octocat: GitHub VS Code Theme for iTerm
https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme
315 stars 22 forks source link

Update v6.3.5 #16

Closed pabloverduzco closed 1 month ago

pabloverduzco commented 2 months ago

The main motivation for this change was that the link for the GitHub Light High Contrast theme was redirecting to a 404 (Not Found) error. Upon investigation, it was discovered that this was due to a typo in the filename.

Changes

cdalvaro commented 1 month ago

Hi @pabloverduzco! Thank you for opening this issue!

I'm not sure why you have closed it, since you were right renaming the file!

pabloverduzco commented 1 month ago

Hello @cdalvaro! I hope you're doing well. I apologize for closing the PR. I was actually about to open a new one with signed commits since this one is blocked for that reason. Do you have any suggestions on how I should proceed? I'd appreciate your input on this.

cdalvaro commented 1 month ago

Hi @pabloverduzco, feel free to make a git push --force to this branch or create a new PR. Whatever you prefer!

pabloverduzco commented 1 month ago

Hello again, @cdalvaro. I apologize for the inconvenience with the commit signatures. I was experiencing some issues with my GPG key configuration, which is why I force-pushed the commits multiple times. Thank you for your patience. I'm excited to contribute to this awesome project!

cdalvaro commented 1 month ago

@pabloverduzco, could you change all references to version 6.3.4 in the README.md file to point to the new one?

pabloverduzco commented 1 month ago

Thank you for pointing that out @cdalvaro. I've already updated all references to version 6.3.4 in the README.md file to the new version in my latest commit.

cdalvaro commented 1 month ago

Thank you for your contribution @pabloverduzco!