search

cdalzell / Lahman

R Package Containing Sean Lahman's Baseball Database
https://cran.r-project.org/web/packages/Lahman/Lahman.pdf
77 stars 37 forks source link

2017 data update #38

Closed rcammisola closed 4 years ago

rcammisola commented 6 years ago

Hi,

I wanted to try and update the data so that it included the 2017 season. It seems Sean hasn't had a chance to upload to his site yet, but mentioned that the CSV files exist on github (https://twitter.com/seanlahman/status/974796328130744320)

They're at this location: https://github.com/chadwickbureau/baseballdatabank/

I was going to try and open a PR to add these in. It seems I should be trying to use the inst/scripts to ensure they're correctly saved as Rdata files and appropriate columns set to factors. Is that correct?

friendly commented 6 years ago

We usually do our updates to the R package in the summer, after the dust has settled down, because there are often errors that get corrected after Sean releases the data for the new season.

But the process of updating takes a bit of work, using the scripts in inst/scripts. It is not fully automatic, because sometimes the structure of one or more files has changed. We create a new branch for this work, and @cdalzell now performs the update

rcammisola commented 6 years ago

Ok, no worries. Thanks very much for getting back to me, I look forward to the update

On 23 March 2018 at 13:58, Michael Friendly notifications@github.com wrote:

We usually do our updates to the R package in the summer, after the dust has settled down, because there are often errors that get corrected after Sean releases the data for the new season.

But the process of updating takes a bit of work, using the scripts in inst/scripts. It is not fully automatic, because sometimes the structure of one or more files has changed. We create a new branch for this work, and @cdalzell https://github.com/cdalzell now performs the update

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cdalzell/Lahman/issues/38#issuecomment-375673354, or mute the thread https://github.com/notifications/unsubscribe-auth/ABeqqJK7oToo4djKBj0ZwmHfVbHt1mmxks5thP-KgaJpZM4S4qwZ .

beanumber commented 5 years ago

+1 on this! :smile: