search

cdalzell / Lahman

R Package Containing Sean Lahman's Baseball Database
https://cran.r-project.org/web/packages/Lahman/Lahman.pdf
77 stars 37 forks source link

2019 Data Update #50

Closed cdalzell closed 4 years ago

cdalzell commented 4 years ago

The 2019 data update has been released, time to update and release v8 of this package.

Feature branch: https://github.com/cdalzell/Lahman/tree/feature/2019-data-update

friendly commented 4 years ago

Let's go for it.

seanlahman commented 4 years ago

Let me know if there's anything I can do to help.

Sean Lahman http://seanlahman.com @SeanLahman

On Wed, Feb 19, 2020 at 9:01 AM Michael Friendly notifications@github.com wrote:

Let's go for it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cdalzell/Lahman/issues/50?email_source=notifications&email_token=AA7K2W4W4VDYURTWVMFINJLRDU3VBA5CNFSM4KXYG3O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMH63UY#issuecomment-588246483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7K2W2MSUS4KDFTTTGED2TRDU3VBANCNFSM4KXYG3OQ .

cdalzell commented 4 years ago

Hey @seanlahman,

The CSV data URL on your site (http://www.seanlahman.com/baseball-archive/statistics) is https://github.com/chadwickbureau/baseballdatabank/archive/master.zip

If possible in this package I'd like to link directly to a specific version so that I know which one it was built from. Example: https://github.com/cdalzell/Lahman/blob/1ee0ec60ac9f09d0ecec9677ee1ce40eecc9116b/inst/scripts/readLahman.R#L17

Would pointing to one of the zip files found here be alright?

seanlahman commented 4 years ago

Yeah, absolutely. Good idea.

Sean Lahman http://seanlahman.com @SeanLahman

On Wed, Feb 19, 2020 at 7:55 PM Chris Dalzell notifications@github.com wrote:

Hey @seanlahman https://github.com/seanlahman,

The CSV data URL on your site ( http://www.seanlahman.com/baseball-archive/statistics) is https://github.com/chadwickbureau/baseballdatabank/archive/master.zip

If possible in this package I'd like to link directly to a specific version so that I know which one it was built from. (Ex: https://github.com/cdalzell/Lahman/blob/1ee0ec60ac9f09d0ecec9677ee1ce40eecc9116b/inst/scripts/readLahman.R#L17 )

Would pointing to one of the zip files found here https://github.com/chadwickbureau/baseballdatabank/releases/tag/v2020.1 be alright?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cdalzell/Lahman/issues/50?email_source=notifications&email_token=AA7K2W7TBGBQYXNJRU3N5N3RDXIIDA5CNFSM4KXYG3O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMKKBIQ#issuecomment-588554402, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7K2WY5OTEXSICR26VZOBDRDXIIDANCNFSM4KXYG3OQ .