Fix integration test #308, use GitHub Action + bump gradle

cdancy / jenkins-rest

Java client, built on top of jclouds, for working with Jenkins REST API

Apache License 2.0

387 stars 173 forks source link

Fix integration test #308, use GitHub Action + bump gradle #310

Closed choweiyuan closed 1 year ago

choweiyuan commented 1 year ago

Please do not create a Pull Request without first creating an ISSUE. Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the Pull Request.

Explain the details for making this change: What existing problem does the Pull Request solve? Why is this feature beneficial?

Currently there is no CI Testing. Re-introduce by using GitHub Actions, runs with Java 17 and 11. Runs integration tests too
Fix the integration test that's currently broken.
Bump Gradle to 7.6.2
Bump Shadow Jar to 7.1.1 to allow Java 17 support
Use latest Jenkins LTS

On automtatic closing of ISSUES

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

choweiyuan commented 1 year ago

You can see GitHub actions in action here: https://github.com/choweiyuan/jenkins-rest/actions

cdancy commented 1 year ago

@choweiyuan this is very cool. Give me a couple days to look over things.

Is there anything I need to do on this end once I merge or should it all "just work"? I've been away from the open-source world for the past few years and so am not sure what current "best practices" are and/or how github-actions works.

choweiyuan commented 1 year ago

@choweiyuan this is very cool. Give me a couple days to look over things.

Is there anything I need to do on this end once I merge or should it all "just work"? I've been away from the open-source world for the past few years and so am not sure what current "best practices" are and/or how github-actions works.

@cdancy I think it should just work, famous last words. I cannot recall if there's any permission related setting required.

If not the quickstart guide should be able to guide you to the right direction... The github actions yaml file that I committed is mostly based on that

cdancy commented 1 year ago

@choweiyuan well ... lets merge and see what happens :) You have another PR out so we should be able to see what's going to happen and fix/amend from there.