cdanielmachado / carveme

CarveMe: genome-scale metabolic model reconstruction
Other
153 stars 52 forks source link

Non valid SBML produced #101

Closed smoretti closed 3 years ago

smoretti commented 3 years ago

Hi

I packaged carveme, diamond and gurobi in a container and run the container on a proteome. CarveMe ran quickly and the SBML produced looks promising.

Unfortunately when I sent this SBML (v3) to the SBML validator (http://sbml.org/Facilities/Validator) it returns errors:

e.g. <species id="M_pi_c" name="Phosphate" compartment="C_c" hasOnlySubstanceUnits="true" fbc:chemicalFormula="HPO4;HO4P">

cdanielmachado commented 3 years ago

You're right, thanks for pointing that out. Unfortunately the BIGG database contains multiple formulas for each metabolite. Instead of selecting just one arbitrarily, we opted to include them all, which makes the sbml content invalid. I will try to fix this in the next release.

Regardless of that, this should not affect simulations, and the models should run just fine in tools like reframed, cobrapy, optflux, etc.

smoretti commented 3 years ago

OK, thanks