cdanielmachado / carveme

CarveMe: genome-scale metabolic model reconstruction
Other
152 stars 52 forks source link

gapfill universe flavor #150

Closed JosuaCarl closed 2 years ago

JosuaCarl commented 2 years ago

When passing gapfill -m SNM3 --mediadb "SNM3.tsv" -o "...l" --universe-file "/.../universe_grampos.xml.gz" --fbc .. or gapfill -m SNM3 --mediadb "SNM3.tsv" -o "...l" --universe-file "/.../universe_grampos.xml.gz" --cobra ... to carveme, the error

Traceback (most recent call last):
  File "/home/salatan/anaconda3/bin/gapfill", line 8, in <module>
    sys.exit(main())
  File "/home/salatan/anaconda3/lib/python3.8/site-packages/carveme/cli/gapfill.py", line 118, in main
    maincall(inputfile=args.input,
  File "/home/salatan/anaconda3/lib/python3.8/site-packages/carveme/cli/gapfill.py", line 41, in maincall
    universe_model = load_cbmodel(universe_file)
  File "/home/salatan/anaconda3/lib/python3.8/site-packages/reframed/io/sbml.py", line 148, in load_cbmodel
    load_metabolites(sbml_model, model, flavor, load_metadata)
  File "/home/salatan/anaconda3/lib/python3.8/site-packages/reframed/io/sbml.py", line 220, in load_metabolites
    model.add_metabolite(load_metabolite(species, flavor, load_metadata=load_metadata))
  File "/home/salatan/anaconda3/lib/python3.8/site-packages/reframed/io/sbml.py", line 228, in load_metabolite
    if fbc_species.isSetChemicalFormula():
AttributeError: 'NoneType' object has no attribute 'isSetChemicalFormula'

comes up.

After some error searching, I found, that gapfill.py does only pass the flavor on for your model. Because the standard grampos universe does not use the fbc plugin, ReFramed returns an error when reading in the universe file.

The universe could be read in, when changing load_cbmodel(universe_file) to load_cbmodel(universe_file, flavor="cobra") in gapfill.py.

cdanielmachado commented 2 years ago

The universe file should be in the fbc2 format. Are you using the latest version of CarveMe ?

On Mon, Dec 13, 2021 at 3:08 PM Josua Carl @.***> wrote:

When passing gapfill -m SNM3 --mediadb "SNM3.tsv" -o "...l" --universe-file "/.../universe_grampos.xml.gz" --fbc .. or gapfill -m SNM3 --mediadb "SNM3.tsv" -o "...l" --universe-file "/.../universe_grampos.xml.gz" --cobra ... to carveme, the error

Traceback (most recent call last): File "/home/salatan/anaconda3/bin/gapfill", line 8, in sys.exit(main()) File "/home/salatan/anaconda3/lib/python3.8/site-packages/carveme/cli/gapfill.py", line 118, in main maincall(inputfile=args.input, File "/home/salatan/anaconda3/lib/python3.8/site-packages/carveme/cli/gapfill.py", line 41, in maincall universe_model = load_cbmodel(universe_file) File "/home/salatan/anaconda3/lib/python3.8/site-packages/reframed/io/sbml.py", line 148, in load_cbmodel load_metabolites(sbml_model, model, flavor, load_metadata) File "/home/salatan/anaconda3/lib/python3.8/site-packages/reframed/io/sbml.py", line 220, in load_metabolites model.add_metabolite(load_metabolite(species, flavor, load_metadata=load_metadata)) File "/home/salatan/anaconda3/lib/python3.8/site-packages/reframed/io/sbml.py", line 228, in load_metabolite if fbc_species.isSetChemicalFormula(): AttributeError: 'NoneType' object has no attribute 'isSetChemicalFormula'

comes up.

After some error searching, I found, that gapfill.py does only pass the flavor on for your model. Because the standard grampos universe does not use the fbc plugin, ReFramed returns an error when reading in the universe file.

The universe could be read in, when changing load_cbmodel(universe_file) to load_cbmodel(universe_file, flavor="cobra") in gapfill.py.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cdanielmachado/carveme/issues/150, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATX4VJ5X5NYLVZ7YRU5XXDUQYD57ANCNFSM5J6MCLZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

JosuaCarl commented 2 years ago

Yes you are right, I was using version 1.4.0. Thank you again for your reply, I'm gonna close this now.