search

cdaragorn / Ui-Info-Suite

Mod for Stardew Valley.
87 stars 360 forks source link

Improve petting indicator animation #26

Closed hollowstrawberry closed 3 years ago

hollowstrawberry commented 5 years ago

Replaced "repeating fading" animation with a "bobbing up and down" animation with softer fading.

I believe that the fading, big pause, then sudden reappearance of the old animation was irritating and made it difficult to see which animals actually needed petting.

The new animation instead bobs up and down slowly, which I think is pleasing to the eyes and helps identify the animals very easily.

Given that the _timer object was now obsolete, I removed it and instead called the StartDrawingPetNeeds method inside the OnWarped event, consistent with the call of StopDrawingPetNeeds.

Additionally, I made it so the indicator is only present when the animal is not at max friendship (below 1000), as already having max friendship would make petting unnecessary. If this behavior is not desired by default, I'd suggest making it a toggleable option in a future pull request.

Hope you like it, thanks.

Zamiell commented 3 years ago

This PR has been integrated in Annosz's fork: https://github.com/Annosz/UIInfoSuite2

cdaragorn commented 3 years ago

I'm sorry, I honestly struggled with this one because your code is fine I just don't have the same opinion about this behavior that you do. I actually like the slow fade. I'm going to go ahead and keep that behavior in the mod.