cdaragorn / Ui-Info-Suite

Mod for Stardew Valley.
88 stars 386 forks source link

1.5 Compatibility #56

Closed ishanjalan closed 3 years ago

ishanjalan commented 3 years ago

Compatibility Patch 1.5 update 2

mybe commented 3 years ago

Thank you for this! It is working great on my end.

dy-lin commented 3 years ago

When there's a journal entry, the luck, travelling merchant, and birthday icons overlap:

https://smapi.io/log/72fbf03c8e034074b2a61b0857819974

Screen Shot 2020-12-22 at 11 04 30 PM

SwiftArtery commented 3 years ago

Feel like a bit of an idiot asking this, but does this need compiling or anything? Or do you just drag the "SDVModTest" folder into your mods folder, as you would the full release of the mod?

CipherFrostful commented 3 years ago

you can download the unofficial verison using his edits here https://forums.stardewvalley.net/threads/unofficial-mod-updates.2096/page-4#post-20605

On Thu, Dec 24, 2020 at 8:19 AM Will notifications@github.com wrote:

Feel like a bit of an idiot asking this, but does this need compiling or anything? Or do you just drag the "SDVModTest" folder into your mods folder, as you would the full release of the mod?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cdaragorn/Ui-Info-Suite/pull/56#issuecomment-750881147, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEAIBWZKSXLIDLHL654G3DSWM5UPANCNFSM4VFYYOZQ .

SwiftArtery commented 3 years ago

you can download the unofficial verison using his edits here https://forums.stardewvalley.net/threads/unofficial-mod-updates.2096/page-4#post-20605 On Thu, Dec 24, 2020 at 8:19 AM Will @.***> wrote: Feel like a bit of an idiot asking this, but does this need compiling or anything? Or do you just drag the "SDVModTest" folder into your mods folder, as you would the full release of the mod? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#56 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALEAIBWZKSXLIDLHL654G3DSWM5UPANCNFSM4VFYYOZQ .

Lovely, thank you!

BottledCoochie commented 3 years ago

image Split screen is kinda wonky, the mod thinks the 2nd player is the main mouse and all of the animal icons are offset

Unnoen commented 3 years ago

It seems that something with the "Remixed" bundles option is different, since this still shows what's required for the default bundles on item hover.

cat-a-flame commented 3 years ago

I can confirm: if you chose remix bundles, the required tooltip shows even after donating that item. Also, it shows the default items as required, not the ones you actually need in the remix (there are new ones, some older ones got swapped). Screens attached:

20201227174746_1 20201227174738_1

kpureblade commented 3 years ago

Not sure if this is new to this version since I haven't used it before, and this is based on the unofficial version found on the SDV forums. This mod doesn't appear to play nice with the "Zoom" feature in the vanilla SDV settings. Everything is "off" to the side where it should be. I have my game zoomed out so I can see more, and I see things like the following:

sdv ui bug 1 sdv ui bug 2

Raisolution commented 3 years ago

Not sure if caused by zoom or a bug in general, but the calendar and quest billboard buttons are not working on my side in 1.5

David-Durbin commented 3 years ago

Not sure if caused by zoom or a bug in general, but the calendar and quest billboard buttons are not working on my side in 1.5

They are there, it is just offset up into the area between your inventory and the bottom section. I found that out when clicking on something in the bottom row of the inventory and suddenly the calendar popped up.

Annosz commented 3 years ago

Hello guys! I've also created a compatibility patch in my repository, where I maintain a slightly different version of the mod. You can find the release here.

I will try to fix issues you reported with split screen or zooming. I have already talked with cdaragon in the past, and when he is available, I will try to integrate these changes with his work. As long as it does not happen, I will try to implement requests there.

DiscipleOfEris commented 3 years ago

I've fixed the split screen and ui scale issues with my PR, #61.

cdaragorn commented 3 years ago

I'm sorry but I'm not willing to accept this PR because it's almost entirely you changing my naming and style all over the place. I'm happy to accept help from the community for this mod but please keep your changes to what is needed. Changing style is never needed.