search

cdbattags / lua-resty-jwt

JWT For The Great Openresty
Apache License 2.0
146 stars 44 forks source link

update tests for 1.13.6.2 #3

Closed cdbattags closed 4 years ago

cdbattags commented 6 years ago

@cybrq-as, mind helping me out here when you get a chance? See failing build on Travis:

https://travis-ci.org/cdbattags/lua-resty-jwt/builds/386418835

Again, sorry for doing this on master. Should reach stability in a couple days and do things PR only.

cdbattags commented 6 years ago

Ope... wut, it looks like the response is just out of order? I have no problem changing this myself but I'm curious why this would now be the case?

ghost commented 6 years ago

Could be an updated module. The real fix is usually to order the JSON keys.

mikz commented 6 years ago

We are quite successfully running big test suite in parallel on CircleCI (https://circleci.com/gh/3scale/apicast).

Also we are maintaining OpenResty docker images with luarocks/prove support: https://github.com/3scale/s2i-openresty/releases

Let me know if you want some help getting CI to a good shape. Right now it is using docker image with old OpenResty to run all the tests, so not really practical as it does not test the OpenSSL 1.1.

cdbattags commented 6 years ago

Fixed this with https://github.com/cdbattags/lua-resty-jwt/commit/21edb9b371828711b1b6b45698eead9681c6b7ca! Thanks so much! Would you mind possibly adding any other tests you can think of and opening a PR?