Dependencies do not match description

cdbattags / lua-resty-jwt

JWT For The Great Openresty

Apache License 2.0

146 stars 44 forks source link

Dependencies do not match description #37

Closed barrelmaker97 closed 3 years ago

barrelmaker97 commented 4 years ago

Recently installed this package via luarocks and realized that although this package depends on lua-resty-string and lua-resty-hmac, they're not actually listed in the dependencies in the rockspec file, so luarocks will install this package without verifying that the two dependencies are installed. Happy to make a PR to fix this, but I wanted to ask: what are the minimum acceptable versions of those dependencies?

cdbattags commented 4 years ago

I'm unsure about lua-resty-string but I know that I current bundle lua-resty-hmac with this "rock" as a submodule and an include on the spec.

cdbattags commented 4 years ago

"lua-resty-string" should be any version because very backwards compatible and just check out the commit hash for hmac. More than happy to have a PR for this! The luarocks environment I know is kinda funky