search

cdcseacave / openMVS_sample

OpenMVS usage example
GNU Affero General Public License v3.0
97 stars 50 forks source link

Not using robust.bin in MvgMvs_Pipeline.py #5

Closed lufi0401 closed 5 years ago

lufi0401 commented 5 years ago

Hi, I am using MvgMvs_Pipeline.py and notice that robust.bin is generated from step "Colorized robust triangulation" but isn't used to export to openMVS (sfm_data.bin is used instead): https://github.com/cdcseacave/openMVS_sample/blob/b119f9b131cbc48870ce65ed4c6693ae7f95f64f/MvgMvs_Pipeline.py#L120-L125 Is that intentional? Thanks for the help.

cdcseacave commented 5 years ago

OpenMVG suffered changes since the moment this script was written, but I did not follow them, so I do not know about the existance of that file and what is suppoed to contain; the best is to ask @pmoulon which is the final SfM scene than should be further used for densification

pmoulon commented 5 years ago

Using sfm_data.bin is ok. The robust.bin step and file is a optional step that is included in the basic python sample to explain the possibilities of the OpenMVG API.

So basically you can remove those two step:

[   "Structure from Known Poses",
                os.path.join(OPENMVG_BIN,"openMVG_main_ComputeStructureFromKnownPoses"),
                ["-i", "%reconstruction_dir%/sfm_data.bin", "-m", "%matches_dir%", "-f", "%matches_dir%/matches.f.bin", "-o", "%reconstruction_dir%/robust.bin"]],
            [   "Colorized robust triangulation",
                os.path.join(OPENMVG_BIN,"openMVG_main_ComputeSfM_DataColor"),
                ["-i", "%reconstruction_dir%/robust.bin", "-o", "%reconstruction_dir%/robust_colorized.ply"]],
lufi0401 commented 5 years ago

Thanks both for the answer!