As discussed in https://github.com/cdecker/lightning-integration/pull/62#discussion_r306429218 , if you're testing this using the included Dockerfile (which is what I find most convenient personally), any changes made locally to makefile or any python file will be ignored as if nothing was done because the Dockerfile always uses the master of this repository instead of your local changes.
This fixes this.
The line COPY . /root/lightning-integration/ is ugly and we could do better, but right now that would result in a lot of individual COPY lines in the Dockerfile. Perhaps we can avoid this in the future by restructuring directories differently. For example, moving all the python code to one directory to copy it at once in a single COPY.
This should also make the build slightly faster by avoiding one git clone.
cdecker
commented
5 years ago
As discussed in https://github.com/cdecker/lightning-integration/pull/62#discussion_r306429218 , if you're testing this using the included Dockerfile (which is what I find most convenient personally), any changes made locally to makefile or any python file will be ignored as if nothing was done because the Dockerfile always uses the master of this repository instead of your local changes.
This fixes this. The line
COPY . /root/lightning-integration/is ugly and we could do better, but right now that would result in a lot of individual COPY lines in the Dockerfile. Perhaps we can avoid this in the future by restructuring directories differently. For example, moving all the python code to one directory to copy it at once in a single COPY.This should also make the build slightly faster by avoiding one git clone.
Note: This seems to be "passing" the travis tests (ie seems it will fail by 50 min timeout) in https://github.com/jtimon/lightning-integration/pull/3