search

cdelker / schemdraw

MIT License
103 stars 20 forks source link

Missing symbols for NMos, PMos #3

Closed dtmaidenmueller closed 1 year ago

dtmaidenmueller commented 1 year ago

There aren't symbols for NMos/PMos devices with/without body diodes.

Note: I've already created a local branch adding these symbols to 'transistors.py'. A preview is provided below.

nmos

dtmaidenmueller commented 1 year ago

What process is preferred for contributing to this project? Should I fork it and create a pull request from that fork, or should I create a new branch under the project here and create a pull request from that branch?

cdelker commented 1 year ago

Looks good. Go ahead and fork and do a pull request.

dtmaidenmueller commented 1 year ago

Do you prefer the original (larger) version, or this version which is only slightly larger in diameter than the BJTs? nmos In the image below I have added a circle in red showing the bounding circle for the BJTs. nmos

dtmaidenmueller commented 1 year ago

I think the smaller versions work better in context with the other components. For example:

half-bridge