search

cdelker / schemdraw

MIT License
112 stars 21 forks source link

Font Padding #44

Closed jodalyst closed 3 months ago

jodalyst commented 3 months ago

With the commit at 4c1a8f810e53c0f95885cb33bfa89574ea96a61e a lot of previous schematics I've done have their labels all offset downwards just a bit. It is just a shade and in many things is not noticed, but in a lot of integrated circuits, it shows up. I can see why/how roughly refactoring padding on text (going off commit) could/might do that, but some of the test notebooks seem to have issues now. In particular, when I build the test_intcircuits.ipynb with any commit after/including the one stated above the labels do not look correct. The impact on most IC devices but especially the seven-segment display is readily apparent. I might dig to see if there's something up with how that got modified, but I'm also wondering is there a way to address this in line with the project vision? Unless I'm doing something stupid with my local runs or something.

cdelker commented 3 months ago

Made a few tweaks in f127fc208b722c7b1e89b6f8df41f976247fce13. Results may vary a bit depending on whether its drawing to matplotlib or direct to svg.

jodalyst commented 3 months ago

This does seem to fix it. Thanks a bunch.