search

cdent / gabbi

Declarative HTTP Testing for Python and anything else
http://gabbi.readthedocs.org/
Other
148 stars 34 forks source link

Implement a workaround for relative Content Handlers #312

Closed scottwallacesh closed 2 years ago

scottwallacesh commented 2 years ago

Fixes, #311

scottwallacesh commented 2 years ago

Did you need me to squash the commits so they're clean?

cdent commented 2 years ago

On squashing: Up to you. Either do it yourself, or I'll do it when merging. If this were something huge it might be a different story.

scottwallacesh commented 2 years ago

Squashed!

cdent commented 2 years ago

I was just getting to merge this and thought of a corner case:

We need to prepend . not append. If we are testing a new version of a handler, and it is local to . but there is an already installed version in site-lib, appending . won't help.

Is that right?

Also, if you can think of a reasonable additional test, it could go in gabbi/tests/test_runner.py

scottwallacesh commented 2 years ago

Good thought. Yes, we now prepend rather than append to the path.