cdent / gabbi

Declarative HTTP Testing for Python and anything else
http://gabbi.readthedocs.org/
Other
148 stars 34 forks source link

Uncap urllib3 #328

Closed kajinamit closed 2 months ago

kajinamit commented 2 months ago

The issue with urllib3 >= 2 was already fixed by [1].

[1] https://github.com/urllib3/urllib3/commit/2459900b10f54326745a597cc1cf2bf8a18f0d56

kajinamit commented 2 months ago

I might be confused by a different problem we had in the past... Let me check the failing job ...

kajinamit commented 2 months ago

Ugh ok so the current problem is different and we have to make wsgi-intercept compatible with urllib3 2 ...

cdent commented 2 months ago

Yeah, the situation with wsgi-intercept is big mess, and I'm struggling to figure it out. There is a pull request https://github.com/cdent/wsgi-intercept/pull/76 that fixes it, but it is super fragile and just has the sense of not being the actually correct solution. If you're interested in looking at that and helping me either make it better or decide that it is okay, please feel free. Thanks.