cdent / wsgi-intercept

Intercept socket connection to wsgi applications for testing
MIT License
42 stars 21 forks source link

Support aiohttp #62

Open vjpr opened 4 years ago

cdent commented 4 years ago

Is this a feature request, without a description it's hard to know what you're after, please follow up with more detail.

If it is a feature request, I'll happily accept a pull request that adds it. I've not had the time to try adding it myself, in part because I assume it is going to be quite challenging to integrate aiohttp's async nature into the decidedly sync nature of wsgi-intercept. Which is not to say it is impossible; it can probably be done, I just haven't the opportunity myself.

Definitely worth investigating.

vjpr commented 4 years ago

I took a look last night. So far I am just monkey patching aiohttp.ClientSession. I'm sure it's more complicated though.

On Tue 21. Apr 2020 at 16:33, Chris Dent notifications@github.com wrote:

Is this a feature request, without a description it's hard to know what you're after, please follow up with more detail.

If it is a feature request, I'll happily accept a pull request that adds it. I've not had the time to try adding it myself, in part because I assume it is going to be quite challenging to integrate aiohttp's async nature into the decidedly sync nature of wsgi-intercept. Which is not to say it is impossible; it can probably be done, I just haven't the opportunity myself.

Definitely worth investigating.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cdent/wsgi-intercept/issues/62#issuecomment-617218202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACEWRJ54MVZIWSXR2NZDXTRNWVCPANCNFSM4MM2K3IQ .