built-in colour scheme is terrible for white background

cdepillabout / pretty-simple

pretty-printer for Haskell data types that have a Show instance

https://hackage.haskell.org/package/pretty-simple

BSD 3-Clause "New" or "Revised" License

243 stars 29 forks source link

built-in colour scheme is terrible for white background #10

Closed jwaldmann closed 7 years ago

jwaldmann commented 7 years ago

try running this in a terminal with a "black letters on white background" setting. (In particular, this is what I use in presentations/teaching, with a projector.)

string quotes are white? - completely invisible.
some parentheses are yellow - nearly invisible.

perhaps make an extra function (pPrintOnWhite).

cdepillabout commented 7 years ago

You're right about this. The colors are currently hard-coded, so I'll make them able to be changed dynamically.

I'll then go and add functions like pPrintOnDarkBg, pPrintOnLightBg, etc. I'll probably have pPrint just call pPrintOnDarkBg.

If you have any opinion on what the names should be, let me know.

Thanks for all of the helpful suggestions, btw!

cdepillabout commented 7 years ago

I've added additional functions for printing on a console with a light background and released a new version to hackage. You can find it here:

https://hackage.haskell.org/package/pretty-simple-2.0.0.0

Feel free to reopen this if you have any suggestions/comments.