search

cdepillabout / pretty-simple

pretty-printer for Haskell data types that have a Show instance
https://hackage.haskell.org/package/pretty-simple
BSD 3-Clause "New" or "Revised" License
243 stars 29 forks source link

Bump to 4.1.1.0 and add changelogs #112

Closed cdepillabout closed 2 years ago

cdepillabout commented 2 years ago

@georgefst @juhp Released to hackage as https://hackage.haskell.org/package/pretty-simple-4.1.1.0

juhp commented 2 years ago

Cool

georgefst commented 2 years ago

Shouldn't this have been a major bump? We've changed the behaviour of a function (albeit in a way that seems very unlikely to actually break any upstream code).

georgefst commented 2 years ago

Actually, maybe golden test failures (even though for golden tests, you probably wouldn't use compact mode)...

cdepillabout commented 2 years ago

Ah, good point. I could see this breaking some golden tests.

You want me to deprecate 4.1.1.0 on Hackage and release 4.2.0.0 instead? Or, we could just wait for someone to complain about it.

georgefst commented 2 years ago

You want me to deprecate 4.1.1.0 on Hackage and release 4.2.0.0 instead?

We should really, but I don't know whether it's worth it after the fact. I'm not personally affected and it's quite likely that no one is.