search

cdepillabout / pretty-simple

pretty-printer for Haskell data types that have a Show instance
https://hackage.haskell.org/package/pretty-simple
BSD 3-Clause "New" or "Revised" License
243 stars 29 forks source link

split the parser into a lexer/parser #16

Closed cdepillabout closed 6 years ago

cdepillabout commented 7 years ago

I think it would be a little easier to change the parsing code if it was split into a lexer/parser (like most programming languages).

I'm going to add the help-wanted label, but I plan on doing this myself when I get the time.

cdepillabout commented 6 years ago

I left this as a comment on #9, but I think it is worth posting here as well:

It is possible that all we really need is a lexer, and not a lexer/parser. It might be possible to figure out the output indentation and color based entirely on lexed input instead of fully parsed input.

andrew-lei commented 6 years ago

Should this be closed?

cdepillabout commented 6 years ago

Yes, thanks a lot!

This was implemented by @andrew-lei in #37!