search

cdepillabout / pretty-simple

pretty-printer for Haskell data types that have a Show instance
https://hackage.haskell.org/package/pretty-simple
BSD 3-Clause "New" or "Revised" License
243 stars 29 forks source link

Remove trailing whitespaces from the end of lines #62

Closed ghallak closed 4 years ago

ghallak commented 4 years ago

Closes: #61

cdepillabout commented 4 years ago

@ghallak Thanks for trying to fix this.

It looks like CI is now failing on some of the doctests with this improvement. Could you fix these up?

https://travis-ci.org/cdepillabout/pretty-simple/jobs/641713245#L468

ghallak commented 4 years ago

I have fixed the doctests expectations and squashed the commits. The CI checks are passing now.

cdepillabout commented 4 years ago

Looks good to me. Thanks!

cdepillabout commented 4 years ago

@ghallak I wasn't planning on creating a Hackage release for this feature, but if you'd like one, please let me know!

ghallak commented 4 years ago

I think it's fine without a Hackage release for this feature, the fixed issue was not causing the biggest problems.

asr commented 4 years ago

I would appreciate a Hackage release including this feature.

cdepillabout commented 4 years ago

No problem, released pretty-simple-3.2.2.0:

https://hackage.haskell.org/package/pretty-simple-3.2.2.0

asr commented 4 years ago

Great! Thanks!